Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage styling: issue #72 #73

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Homepage styling: issue #72 #73

merged 5 commits into from
Jan 17, 2024

Conversation

kailasnadh790
Copy link
Collaborator

@kailasnadh790 kailasnadh790 requested a review from bstopp January 16, 2024 16:44
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 16, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@kailasnadh790 kailasnadh790 requested a review from tmaret January 16, 2024 16:45
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 16, 2024 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/drafts/Kailas/homepage PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to feature/homepage January 16, 2024 17:22 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/homepage January 16, 2024 18:28 Inactive
bstopp
bstopp requested changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@bstopp bstopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the global styles from the Carousel fix.

@kailasnadh790 kailasnadh790 changed the title carousel fix Homepage styling: issue #72 Jan 16, 2024
@kailasnadh790
Copy link
Collaborator Author

@bstopp This PR has global styling for buttons and Section headings as well.

@kailasnadh790 kailasnadh790 requested a review from bstopp January 16, 2024 20:43
@bstopp
Copy link
Collaborator

bstopp commented Jan 16, 2024

Yep, i know. I'd like to see the PR for the bug fix separate from a PR with the global stylings.

@bstopp
Copy link
Collaborator

bstopp commented Jan 16, 2024

Was there not 2 issues being fixed with this one PR?

@kailasnadh790
Copy link
Collaborator Author

@bstopp I had captured them as tasks under one issue #72 .
Let me know if I need to create separate issues and separate the PRs. Sorry for the confusion.

bstopp
bstopp requested changes Jan 16, 2024
View reviewed changes
cigaradvisor/blocks/carousel/carousel.css Outdated Show resolved Hide resolved
cigaradvisor/blocks/carousel/carousel.js Outdated Show resolved Hide resolved
cigaradvisor/styles/styles.css Outdated Show resolved Hide resolved
cigaradvisor/styles/styles.css Outdated Show resolved Hide resolved
cigaradvisor/styles/styles.css Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to feature/homepage January 16, 2024 23:06 Inactive
@kailasnadh790 kailasnadh790 requested a review from bstopp January 16, 2024 23:07
@kailasnadh790 kailasnadh790 merged commit c2522b6 into main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstopp bstopp bstopp approved these changes

@tmaret tmaret Awaiting requested review from tmaret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home page styling
2 participants
@kailasnadh790 @bstopp